Test the Vehicle VIN validator with known good and bad values, fixes … (

#2640) * Test the Vehicle VIN validator with known good and bad values, fixes #2639 * Fix rubocop issues * Deterministically verify vehicle vins, move VIN_REGEX to test file, refactor deterministic tests * Remove duplicate vin regex test Co-authored-by: Vitor Oliveira <vbrazo@gmail.com>
faker-ruby · Jan 24, 2023 · 2f63c85 · 2f63c85
1 parent 9246681
commit 2f63c85
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/lib/faker/default/vehicle.rb b/lib/faker/default/vehicle.rb
@@ -9,7 +9,6 @@ class Vehicle < Base
     VIN_KEYSPACE = %w[A B C D E F G H J K L M N P R S T U V W X Y Z 0 1 2 3 4 5 6 7 8 9].freeze
     VIN_TRANSLITERATION = { A: 1, B: 2, C: 3, D: 4, E: 5, F: 6, G: 7, H: 8, J: 1, K: 2, L: 3, M: 4, N: 5, P: 7, R: 9, S: 2, T: 3, U: 4, V: 5, W: 6, X: 7, Y: 8, Z: 9 }.freeze
     VIN_WEIGHT = [8, 7, 6, 5, 4, 3, 2, 10, 0, 9, 8, 7, 6, 5, 4, 3, 2].freeze
-    VIN_REGEX = /\A[A-HJ-NPR-Z0-9]{17}\z/.freeze
     SG_CHECKSUM_WEIGHTS = [3, 14, 2, 12, 2, 11, 1].freeze
     SG_CHECKSUM_CHARS = 'AYUSPLJGDBZXTRMKHEC'
 

diff --git a/test/faker/default/test_faker_internet.rb b/test/faker/default/test_faker_internet.rb
@@ -62,8 +62,8 @@ def test_username_with_string_arg
   end
 
   def test_username_with_string_arg_determinism
-    deterministically_verify -> { @tester.username(specifier: 'bo peep') }, depth: 4 do |subject|
-      assert_match(/(bo(_|\.)peep|peep(_|\.)bo)/, subject)
+    deterministically_verify -> { @tester.username(specifier: 'bo peep') }, depth: 4 do |username|
+      assert_match(/(bo(_|\.)peep|peep(_|\.)bo)/, username)
     end
   end
 
@@ -236,8 +236,8 @@ def test_deterministic_password_with_compatible_min_length_and_requirements
     [false, true].each do |value|
       min_length = value ? 2 : 1
 
-      deterministically_verify -> { @tester.password(min_length: min_length, mix_case: value, special_characters: !value) }, depth: 4 do |subject|
-        assert_nothing_raised { subject }
+      deterministically_verify -> { @tester.password(min_length: min_length, mix_case: value, special_characters: !value) }, depth: 4 do |password|
+        assert_nothing_raised { password }
       end
     end
   end

diff --git a/test/faker/default/test_faker_vehicle.rb b/test/faker/default/test_faker_vehicle.rb
@@ -4,18 +4,19 @@
 
 class TestFakerVehicle < Test::Unit::TestCase
   WORD_MATCH = /\w+\.?/.freeze
+  VIN_REGEX = /\A[A-HJ-NPR-Z0-9]{17}\z/.freeze
 
   def setup
     @tester = Faker::Vehicle
   end
 
   def test_vin
-    assert_match Faker::Vehicle::VIN_REGEX, @tester.vin
-  end
+    assert valid_vin('11111111111111111') # known valid test string
+    assert valid_vin('FAKERGEM5FAKERGEM') # valid checksum
+    refute valid_vin('ABCDEFGH123456789') # invalid checksum
 
-  def test_vin_validity
-    100.times do
-      assert valid_vin(@tester.vin)
+    deterministically_verify -> { @tester.vin }, depth: 4 do |vin|
+      assert valid_vin(vin)
     end
   end
 
@@ -117,7 +118,7 @@ def doors_condition(doors)
   end
 
   def valid_vin(vin)
-    if vin && vin =~ Faker::Vehicle::VIN_REGEX
+    if vin && vin =~ VIN_REGEX
       total = 0
       vin.chars.each_with_index do |char, index|
         value = (char =~ /\A\d\z/ ? char.to_i : Faker::Vehicle::VIN_TRANSLITERATION[char.to_sym])