-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish letter and Faker::Internet.user_name (expected: replacement by ASCII letters, what happens: removal) #168
Comments
I am using following fix in my script:
|
Note for someone willing to fix this: maybe stringex does the trick |
It seems that Polish is not listed below "Currently, built-in translations are available for the following languages:". |
@matkoniecz could we close this issue or you guys need help to solve it? |
@vbrazo At time of reporting it Faker was unable to handle UTF-8 letters, even by converting them to ASCII. I see no reason to close this unless this issue is now fixed. |
@matkoniecz ok cool! Thanks for the quick follow-up. I'm going to take a look at this issue in the next days. Lemme know if you have any new ideas on how to solve it. |
As I reread it - I would expect Faker to just handle UTF-8 text. Originally mentioned conversion to ASCII is an overcomplicated crutch that should not be necessary. |
returns
I would expect it to return
Affected signs: ą, Ą ć Ć ę Ę ł Ł ń Ń ó Ó ś Ś ź Ź ż Ż
Commonly accepted and widespread method of dealing with inability of many systems to use proper UTF-8 is to replace this letters with closest ASCII letter.
The text was updated successfully, but these errors were encountered: