Refactor Faker::Educator and add docs #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize the to do the dynamic generation of strings in the YML itself. Also reformat the YML to use one line per entry.
Closed
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
|
@vbrazo can I get a review of this PR as well? :) |
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Refactor Faker::Educator. Reorganize the to do the dynamic generation of strings in the YML itself. Also reformat the YML to use one line per entry. * Add YARD docs for Faker::Educator. * Sorting things like a monkey * More sorting * Update educator.yml * Update educator.yml
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Refactor Faker::Educator. Reorganize the to do the dynamic generation of strings in the YML itself. Also reformat the YML to use one line per entry. * Add YARD docs for Faker::Educator. * Sorting things like a monkey * More sorting * Update educator.yml * Update educator.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors Faker::Educator to use the
parsemethod instead of generating the returned strings in the Ruby code. The behavior of the Educator class methods shouldn't have changed.It also reformats the YML file to use one line per entry, and adds YARD docs.