Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add YARD docs to Faker::SlackEmoji #1956

Merged
merged 3 commits into from May 17, 2020
Merged

add YARD docs to Faker::SlackEmoji #1956

merged 3 commits into from May 17, 2020

Conversation

marientje
Copy link
Contributor

Issue#

#1762

Description:

Adds YARD docs for Faker::SlackEmoji.

@Zeragamba @koic
Update lib/faker/default/slack_emoji.rb
b1a81d6 
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@koic
Copy link
Member

koic commented May 17, 2020

This looks good except for the missing period at the end of sentence 👍

@marientje
Copy link
Contributor Author

Thank you for the review, I added the missing periods 😃

@koic koic merged commit e1dd8f5 into faker-ruby:master May 17, 2020
@koic
Copy link
Member

koic commented May 17, 2020

Thanks!

@connorshea connorshea mentioned this pull request May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marientje @koic @Zeragamba