Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LoremPixel #2590

Merged
merged 9 commits into from
Nov 1, 2022
Merged

Deprecate LoremPixel #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d64675
added deprecation warning
uzorjchibuzor Oct 13, 2022
d1ebe99
included serach terms in method call
uzorjchibuzor Oct 13, 2022
a95e321
test for lorem_pixel redirection to loremflickr with options
uzorjchibuzor Oct 13, 2022
7087b7b
used Gem::Deprecate to show warning message
uzorjchibuzor Oct 17, 2022
dd3d628
deprecation message showing
uzorjchibuzor Oct 17, 2022
ed395ad
test for deprecation warning
uzorjchibuzor Oct 17, 2022
2b4eb9d
fix rubocop offences
uzorjchibuzor Oct 17, 2022
60fcc28
simplified test for deprecation
uzorjchibuzor Nov 1, 2022
5b5bc2f
fix rubocop offense on the test file
uzorjchibuzor Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/faker/default/lorem_pixel.rb
View file
Open in desktop
Expand Up @@ -3,6 +3,8 @@
module Faker
class LoremPixel < Base
class << self
extend Gem::Deprecate

SUPPORTED_CATEGORIES = %w[abstract
animals
business
Expand Down Expand Up @@ -55,6 +57,7 @@ def image(size: '300x300', is_gray: false, category: nil, number: nil, text: nil
url_parts += [category, number, text].compact
url_parts.join('/')
end
deprecate :image, 'Faker::LoremFlickr.image', 2022, 12
# rubocop:enable Metrics/ParameterLists
end
end
Expand Down
8 changes: 8 additions & 0 deletions test/faker/default/test_lorem_pixel.rb
View file
Open in desktop
Expand Up @@ -7,6 +7,14 @@ def setup
@tester = Faker::LoremPixel
end

def test_image_deprecation_message
_out, err = capture_output do
@tester.image(size: '3x3')
end

assert_match(/Faker::LoremPixel.image is deprecated; use Faker::LoremFlickr.image instead\./, err)
end

def test_lorempixel
refute_nil @tester.image.match(%r{https://lorempixel\.com/(\d+/\d+)})[1]
end
Expand Down