Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sport docs #2716

Merged
merged 3 commits into from Feb 21, 2023
Merged

Update sport docs #2716

merged 3 commits into from Feb 21, 2023

Conversation

clementf
Copy link
Contributor

Summary

Note: first attempt was #2687

I've noticed recently while using faker that all the examples in the docs for the Faker::Sport class contain a typo (they have an additional s in the class name).

PS: thank you for creating, and maintaining this ruby gem, which I've been using in a lot of projects!

@clementf clementf mentioned this pull request Feb 21, 2023
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @clementf 🎉

@stefannibrasil stefannibrasil merged commit 6859248 into faker-ruby:main Feb 21, 2023
@clementf
Copy link
Contributor Author

Thank you for your patience @stefannibrasil 😊

@clementf clementf deleted the update-sport-docs branch February 22, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants