Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translations for Sports category. #2770

Merged
merged 1 commit into from May 31, 2023

Conversation

yamat47
Copy link
Contributor

@yamat47 yamat47 commented May 30, 2023

Motivation / Background

I have added Japanese translations for sports names in the given repository. These changes are important as they increase the accessibility and inclusivity of the project for Japanese speakers and those working with Japanese data. The Japanese translations were added because they were previously missing from the sports names data. All translations were cross-referenced with the official Olympics website to ensure the highest level of accuracy.

Additional information

Aside from the Olympics website, translations were also checked for accuracy with native Japanese speakers to further ensure quality. Please note that some sport names in Japanese are the same as in English, as they are commonly used in their English forms in Japan.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

This commit introduces Japanese translations to the Sports category.
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding more translations! 🙏 👏

LGTM, but I don't speak Japanese. Hopefully we can get more 👀 on this one.

@nakatomotoi
Copy link

@yamat47 @thdaraujo
I'm a Japanese speaker.
This change would not be a problem in terms of Japanese.

@thdaraujo thdaraujo merged commit dda4070 into faker-ruby:main May 31, 2023
7 checks passed
@thdaraujo
Copy link
Contributor

awesome, thank you @nakatomotoi @yamat47 👏

@yamat47 yamat47 deleted the add-ja-locales-for-sport branch May 31, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants