Add Faker::Commerce.rating

[bradly]

Motivation / Background

This Pull Request has been created because I needed to generate ratings for a product.

Additional information

My use case was for a rating for a product so I put this in Fake::Commerce, but there are other generators that could have a ratings as well: App, Book, Game, Movie, Restaurant, etc..

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug, refactor something, or add a feature.
• Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

• Open an issue first for discussion before you write any code. New generator request: Faker::Commerce.rating #2809
• Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
• You've reviewed and followed the Documentation guidelines.

[stefannibrasil]

What do you think of adding a check here for the decimals to be within a reasonable limit? and checking if the decimals can't be negative?

[stefannibrasil]

We also have a Japanese commerce locale. Could you update that as well?

[stefannibrasil]

Thank you for submitting the changes @bradly

Could you add the following tests as well:

• Verify that as_string works with other arguments. For example: Faker::Commerce.rating(range: 0..10, decimals: 2, as_string: false) returns a string for me.
• Could you clarify more about the use case for as_string? Is that something the user can parse on their own if they need it? I'm a bit unsure we should have the responsibility of converting the Rating.
• What do you think of adding upper limits to both range and decimals? People could enter high numbers for them, which would crash the generator.
• Have you considered returning an ArgumentError for when the decimals are not positive? That way, the user can identify what the error is and fix it, then try again. If we just ignore it, they won't know what happened. We can also handle range and decimals as ArgumentError when they exceed the upper limit. What upper limits do you suggest for them?

Thanks!

[stefannibrasil]

hi @bradly are you still interested in working on this one? Thanks!

[stefannibrasil]

Hi @bradly I will close this since it hasn't been active for a couple of months. Feel free to re-open and rebase with main if you're still planning on working on this. Thanks!