Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed tests from x.times loop to deterministically_verify helper. #2813 issue #2816

Merged
merged 2 commits into from Aug 31, 2023
Merged

Changed tests from x.times loop to deterministically_verify helper. #2813 issue #2816

merged 2 commits into from Aug 31, 2023

Conversation

fernandomenolli
Copy link
Contributor

Motivation / Background

This Pull Request fixes #2813 issue.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

stefannibrasil
stefannibrasil approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fernandomenolli 🎉

test/faker/default/test_faker_city.rb
100.times do
cities = ['west alice', 'west smith', 'west aliceburg', 'west smithburg', 'aliceburg', 'smithburg']
city = Faker::Address.city
cities = ['west alice', 'west smith', 'west aliceburg', 'west smithburg', 'aliceburg', 'smithburg']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@stefannibrasil stefannibrasil merged commit 1314040 into faker-ruby:main Aug 31, 2023
7 checks passed
@stefannibrasil stefannibrasil mentioned this pull request Aug 31, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use deterministic helper to execute the test provided in the block successive number of times
2 participants
@fernandomenolli @stefannibrasil