Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecate safe_email and free_email methods #2841

Merged
merged 7 commits into from Nov 22, 2023
Merged

Remove deprecate safe_email and free_email methods #2841

merged 7 commits into from Nov 22, 2023
+0 −191

Conversation

hatsu38
Copy link
Contributor

@hatsu38 hatsu38 commented Oct 17, 2023 •
edited

Motivation / Background

FYI: #2733

The safe_email and free_email methods are slated for deprecation in October 2023. Therefore, they are being removed in this pull request.

Additional information

bundle exec rake test
スクリーンショット 2023-10-18 1 51 30

bundle exec rubocop
スクリーンショット 2023-10-18 1 51 39

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

@hatsu38 hatsu38 changed the title Remove duplicate safe_email and free_email methods Remove deprecate safe_email and free_email methods Oct 29, 2023
stefannibrasil
stefannibrasil reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left one small comment that needs to be addressed. This PR also needs to be rebased with main to fix the merge conflicts. Thanks!

lib/faker/default/internet.rb
@@ -50,42 +50,6 @@ def email(name: nil, separators: nil, domain: nil)
construct_email(sanitized_local_part, generate_domain)
end

##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove extend Gem::Deprecate from line 18 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! fix: 68f26b5

@hatsu38
Copy link
Contributor Author

hatsu38 commented Nov 22, 2023

I fixed conflicts with main!

stefannibrasil
stefannibrasil approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks for doing this! 🚀

@stefannibrasil stefannibrasil merged commit 505a667 into faker-ruby:main Nov 22, 2023
7 checks passed
@hatsu38 hatsu38 deleted the feature/remove-safe_email branch November 22, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees
No one assigned
Labels
🙏🏽 PR: Needs Further Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hatsu38 @stefannibrasil @thdaraujo