Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec on TestFakerFile#test_file_name #2868

Merged

Conversation

keshavbiswa
Copy link
Contributor

Motivation / Background

Fixes: #2867

The regex matcher for test_file_name wasn't matching the extensions with a number (.mp3, .mp4), this PR updates the matcher to include alphanumeric to it.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 😆

@thdaraujo thdaraujo changed the title Fix flaky spec on test_file_name #2867 Fix flaky spec on TestFakerFile#test_file_name Dec 13, 2023
@thdaraujo thdaraujo merged commit 0576cce into faker-ruby:main Dec 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky spec on TestFakerFile#test_file_name
2 participants