New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faker::Games::Dota
missing quotes and new heroes
#2907
base: main
Are you sure you want to change the base?
Conversation
Bane - https://dota2.fandom.com/wiki/Bane/Responses Batrider - https://dota2.fandom.com/wiki/Batrider/Responses Bloodseeker - https://dota2.fandom.com/wiki/Bloodseeker/Responses Bounty Hunter - https://dota2.fandom.com/wiki/Bounty_Hunter/Responses Broodmother - https://dota2.fandom.com/wiki/Broodmother/Responses
The hero is called `Centaur Warrunner` but in `quotes` he's called just `centaur`. It causes problems if users try to generate quote by `parameterize(separator: '_')` the name. I left old `centaur` to not brake people's code.
Dark Seer - https://dota2.fandom.com/wiki/Dark_Seer/Responses Dark Willow - https://dota2.fandom.com/wiki/Dark_Willow/Responses Dawnbreaker - https://dota2.fandom.com/wiki/Dawnbreaker/Responses Dazzle - https://dota2.fandom.com/wiki/Dazzle/Responses Death Prophet - https://dota2.fandom.com/wiki/Death_Prophet/Responses Disruptor - https://dota2.fandom.com/wiki/Disruptor/Responses Drow Ranger - https://dota2.fandom.com/wiki/Drow_Ranger/Responses
Thank you! What if we fixed this by making sure that if a hero does not have a quote, we return nil instead of an error? Additionally, we could remove the default hero as well. Or we can also remove the dependency between hero and quote. What do you think? |
Thanks for checking my PR!
Yes, I can implement that. But I still want to populate quotes for every hero. So I think it's unnecessary to remove dependency between heroes and quotes.
After populating all quotes, yeah. And also replace this variable with @heroes = Faker::Base.fetch_all('games.dota.hero').map { |hero| hero.gsub(/\W+/, '_').downcase } What's the best way for me to proceed with this PR? I don't want to spam contributors notifications, putting more commits in this PR will do exactly that. My suggestion is
|
HI @arthurka-o thank you for you comment! Catching up with the reviews now.
It doesn't spam us when you push commits to a open PR 👍
Are there still more things to add besides the ones being added here? I'd rather remove the heroes that don't have the quotes for now; we also don't want to add every single hero and subsequent quote -- that's too much. We'll probably organize things around and adding more stuff means more things to shuffle later. This one looks good to me and it can also handle the case when the |
Motivation / Background
This Pull Request has been created because I was trying to generate a quote from random Dota 2 heroes.
And encountered that a lot of heroes don't have any quotes for them. That's why I decided to fill missing quotes.
For this PR I only added missing quotes for heroes from A to D. I'm not sure that Faker team will accept those changes, so I decided to stop on this for now. I'll do other heroes quotes after seeing the green light.
And also I added two missing heroes. This is a small change so I decided to put it in this PR.
Additional information
I also added
centaur_warrunner
quotes by copingcentaur
quotes. My reasoning is in the commit message.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
If you're proposing a new generator or locale: