Performance: Sample arrays instead of performing shuffle and slice

[alextaujenis]

Motivation / Background

This Pull Request has been created because shuffling an array then slicing the required amount of array items is less efficient than sampling the array. The sample algorithm picks random items and is more efficient than reordering the entire array.

Additional Information

This PR simply takes each instance of shuffle and slice across the library:

shuffle(word_list)[0, resolved_num]

and replaces it with sample:

sample(word_list, resolved_num)

The internal Faker.sample method has been used to replace the shuffle method in order to still provide deterministic random values.

Performance Benchmark

You can see from the benchmark below that after replacing "shuffle and slice" with "sample" the methods are up to 17.7% faster:

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug, refactor something, or add a feature.
• Tests and Rubocop are passing before submitting your proposed changes.
• Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
• You've reviewed and followed the Contributing guidelines.

[alextaujenis]

This test keeps breaking with the following output:

 Failure: test_omniauth_linkedin(TestFakerInternetOmniauth):
  </(rolf(.|_)o'connell|o'connell(.|_)rolf)@(.*).(example|test)/i> was expected to be =~
  <"connell_rolf_o@ritchie.example">.
/home/runner/work/faker/faker/test/faker/default/test_faker_omniauth.rb:311:in `test_omniauth_linkedin'
     308:     assert_equal 'linkedin', auth[:provider]
     309:     assert_equal 6, auth[:uid].length
     310:     assert_equal 2, word_count(info[:name])
  => 311:     assert_match email_regex(first_name, last_name), info[:email]

It appears the problem is because Faker::Omniauth is initialized with:

@name = name || "#{Name.first_name} #{Name.last_name}"
@email = email || Internet.email(name: self.name)

... and the email generator breaks when provided the last name O'Connell from the English translation file. Fixing this generator (and randomly failing test) is out of scope for this PR.

[thdaraujo]

this makes sense to me and it's a nice improvement, thanks for working on this!