-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added skip_warning ability to deprecators for tests #2956
base: main
Are you sure you want to change the base?
Added skip_warning ability to deprecators for tests #2956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thank you!
@thdaraujo could you give a review when you can? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for our own testing purposes, right?
If yes, then it looks good to me - but left a suggestion so we don't use a class variable.
And Faker::Theater
still displays a warning, not sure why.
@thdaraujo Thanks, I'll take a look at your suggestion and also figure out why you're seeing the deprecation message. |
@thdaraujo @stefannibrasil I have fixed the issue and have updated your requested changes. |
Motivation / Background
Fixes: #2948
This Pull Request has been created because We want the ability to silence output warnings for Deprecated Generators in tests.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
If you're proposing a new generator or locale: