Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format height and width type to pass jsx style #62

Merged
merged 2 commits into from Dec 17, 2020
Merged

format height and width type to pass jsx style #62

merged 2 commits into from Dec 17, 2020

Conversation

AkaiZhao
Copy link

@AkaiZhao AkaiZhao commented Dec 7, 2020

When using this library, I found that if height or width are prop as string like "64", the element size of svg will not change correctly.

@coveralls
Copy link

coveralls commented Dec 7, 2020 •
edited

Coverage Status

Coverage increased (+4.2%) to 79.167% when pulling 0e6ee43 on AkaiZhao:check-style-type into a9452fe on fakiolinho:master.

@fakiolinho fakiolinho merged commit 4982465 into fakiolinho:master Dec 17, 2020
@fakiolinho
Copy link
Owner

Thanks @AkaiZhao that was really useful 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AkaiZhao @coveralls @fakiolinho