Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Mock source extensions to simplify testing #27

Merged
merged 4 commits into from
May 4, 2023
Merged

[feature] Mock source extensions to simplify testing #27

merged 4 commits into from
May 4, 2023

Conversation

fako1024
Copy link
Owner

@fako1024 fako1024 commented May 2, 2023

Provides some convenience methods to simplify testing (and includes some very minor code cleanup).

Closes #26

@fako1024 fako1024 added the enhancement New feature or request label May 2, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone May 2, 2023
@fako1024 fako1024 requested a review from els0r May 2, 2023 12:00
@fako1024 fako1024 self-assigned this May 2, 2023
@fako1024 fako1024 linked an issue May 2, 2023 that may be closed by this pull request
Mock source extensions to simplify testing #26
Closed
2 tasks
els0r
els0r approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my full trust 😍 . Especially after I read return IPLayer((*p)[int((*p)[1])+PacketHdrOffset:]), the mother of all casts.

@fako1024 fako1024 merged commit 57f5e00 into main May 4, 2023
4 checks passed
@fako1024 fako1024 deleted the 26-mock-source-extensions-to-simplify-testing branch May 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@els0r els0r els0r approved these changes

Assignees

@fako1024 fako1024

Labels
enhancement New feature or request
Projects
None yet
Milestone
Initial Release (v1)
Development

Successfully merging this pull request may close these issues.

Mock source extensions to simplify testing
2 participants
@fako1024 @els0r