Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Prevent access to blocks potentially still being in the buffer after closing mock source #63

Merged

Conversation

fako1024
Copy link
Owner

@fako1024 fako1024 commented Aug 29, 2023

@els0r This was a quick fix for a very minor issue I encountered in tests.

Closes #62

@fako1024 fako1024 added the bug Something isn't working label Aug 29, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone Aug 29, 2023
@fako1024 fako1024 requested a review from els0r August 29, 2023 09:30
@fako1024 fako1024 self-assigned this Aug 29, 2023
@fako1024 fako1024 linked an issue Aug 29, 2023 that may be closed by this pull request
Copy link
Collaborator

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed.

@fako1024 fako1024 merged commit 1a70846 into main Sep 3, 2023
4 checks passed
@fako1024 fako1024 deleted the 62-sporadic-test-failure-for-mock-source-in-no-drain-mode branch September 3, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic test failure for mock source in no-drain mode
2 participants