chore: revisit release process #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
ruslan/fea-2222-revisit-release-process
branch
2 times, most recently
from
a984b83
to
dcfb5ef
Compare
efiop
force-pushed
the
ruslan/fea-2222-revisit-release-process
branch
from
dcfb5ef
to
dae789e
Compare
|
Merging to release cloudpickle/pydantic and debug the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping
poetry, usingsetuptools_scmwith new monorepo tags and using those to do proper github releases.Also provides useful
devandtestextras infalthat allow you to install everything you need for development/testing.New release process goes as follows: either trigger a github release creation in the workflow dispatch (see
create-release.yaml) or manually create a github release (not recommended, since this is a monorepo and git tags need a particular format, e.g.isolate_proto_v1.2.3). Then a github release is created with a tag that triggers a pypi release (seerelease.yaml).We did lose a single-workflow to release fal and bump
isolate_protoin its dependencies though, so one needs to releaseisolate_proto, then bump in fal and then release fal.As a result of this, we will get releases in https://github.com/fal-ai/fal/releases with changelogs and proper tags. Also this won't create any PRs anymore like we used to #174 , since there is no need anymore, which is nice.
Note that testing release without doing a release is a bit challenging, so I will be around to do the next one just to catch/fix any potential problems.
Fixes #150