feat(static): set Content-Length for static file responses
#1991
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6669 6674 +5
Branches 1079 1079
=========================================
+ Hits 6669 6674 +5
Continue to review full report at Codecov.
|
|
We already have unit tests covering ASGI too, but I will check if all the functionality is verified in unit tests as well. Otherwise, ASGI has no concept of |
| # Ignore Range headers for zero-byte files; just serve the empty body | ||
| # since Content-Range can't be used to express a zero-byte body | ||
| return fh, None | ||
| # NOTE(tipabu): Ignore Range headers for zero-byte files; just serve |
There was a problem hiding this comment.
For reference: @tipabu I prefixed your comments with your GH nick, and refactored the code slightly to work around issues with buggy sendfile implementations in many popular WSGI servers such as Gunicorn, uWSGI, etc.
Also fix range request support across different WSGI servers by always providing a Python wrapper without a file descriptor, since many
sendfileimplementations are buggy wrt not respecting the current file offset; both Gunicorn (benoitc/gunicorn#2669) and uWSGI are affected according to my testing.There is still an open question remaining what to do with Meinheld: I've filed this as a separate issue (#1992).