Global hooks don't play well with exceptions

[hanjianwei]

I'm writing a simple RESTful server using falcon. To support CORS I write a global after hook who adds extra response headers. But I found the hook does not work with exceptions. This is the code:

import falcon

def crossdomain(req, resp):
    resp.set_header('Access-Control-Allow-Origin', '*')

def check_auth(req, resp, params):
    if not req.auth:
        raise falcon.HTTPUnauthorized('Unauthorized', 'You should login first.')


class Todo(object):
    def on_get(self, req, resp):
        resp.status = falcon.HTTP_200
        resp.body = '{"message": "welcome"}'

api = application = falcon.API(before=[check_auth], after=[crossdomain])

todo = Todo()
api.add_route('/todo', todo)

If authorization information is provided everything is ok:

~ ❯❯❯ http --auth falcon:falcon get http://localhost:8000/todo
HTTP/1.1 200 OK
Connection: close
Date: Thu, 27 Mar 2014 07:57:38 GMT
Server: gunicorn/18.0
access-control-allow-origin: *
content-length: 22
content-type: application/json; charset=utf-8

{
    "message": "welcome"
}

But If no authorization provided, an exception should be raised. And the extra header is not added:

~ ❯❯❯ http get http://localhost:8000/todo
HTTP/1.1 401 Unauthorized
Connection: close
Date: Thu, 27 Mar 2014 07:57:17 GMT
Server: gunicorn/18.0
content-length: 77
content-type: application/json; charset=utf-8

{
    "description": "You should login first.",
    "title": "Unauthorized"
}

wsgi middleware should be a quick solution. But I wonder is there a falcon way to do that?

Thanks!

[kgriffs]

This should be fixed as of ff35bf3. Can you verify? Thanks!

[hanjianwei]

Yes, it works!

Thanks!