Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide a way to set raw cookie headers #1414

Merged
merged 3 commits into from
Feb 14, 2019

Commits on Feb 13, 2019

  1. feat: Provide a way to set raw cookie headers

    Previously, setting raw cookies was not supported without having
    to subclass Response and override several methods. This patch
    adds official support for this functionality, while also explicitly
    disallowing the use of Set-Cookie with certain generic header
    manipulation methods that have semantics that are incompatible
    with Set-Cookie.
    
    BREAKING CHANGE: Previously, several methods in the Response class
    	could be used to attempt to set raw cookie headers. However,
    	due to the Set-Cookie header values not being combinable
    	as a comma-delimited list, this resulted in an unexpected and/or
    	incorrect response being constructed for the user agent in
    	the case that more than one cookie was being set.
    
    Fixes falconry#1265
    kgriffs committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    45d7723 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Configuration menu
    Copy the full SHA
    a79f417 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4632bb0 View commit details
    Browse the repository at this point in the history