Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(response): Add an FAQ entry for response attributes #1529

Merged
merged 5 commits into from
May 8, 2019

Conversation

nZac
Copy link

@nZac nZac commented May 6, 2019

Fixes GH-1375

@nZac nZac requested a review from a team May 6, 2019 22:31
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #1529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1529   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        2565    2565           
  Branches      391     391           
======================================
  Hits         2565    2565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db86c6d...b16e1ed. Read the comment docs.

Copy link
Member

@jmvrbanac jmvrbanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, but outside of that, it looks good!

docs/user/faq.rst Outdated Show resolved Hide resolved
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good 👍

@vytas7 vytas7 merged commit 71bb7b2 into falconry:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: How to properly return different kinds of responses?
3 participants