feat(general): support Jython 2.7rc2 #488
Conversation
|
Er, hmm, how do I actually get Travis to run? |
csojinb
changed the title
| @@ -1,6 +1,7 @@ | |||
| language: python | |||
| sudo: false | |||
| install: pip install tox coveralls --use-mirrors | |||
| before_install: if [ "$JYTHON" == "true" ]; then travis_scripts/install_jython2.7.sh; fi | |||
There was a problem hiding this comment.
These single-line-ifs all over the place are so ugly. If someone has thoughts on how to do this better, would love to hear them!
I could pull the ifs and all into travis_scripts perhaps.
|
Is there a way to optionally skip the coverage tests? It would be nice to be able to skip them for Jython, without causing them to not run by default. Is there some better solution for coverage's incompatibility with Jython than just skipping those tests? |
csojinb
force-pushed
the
jython_support
branch
2 times, most recently
from
d8e61a3
to
1caee9d
Compare
|
Argh. I think it didn't actually run with Jython, otherwise I think the coverage tests would have all failed. |
csojinb
force-pushed
the
jython_support
branch
3 times, most recently
from
e04b330
to
12f23d0
Compare
|
Okay, here's the deal. I was successful in getting Jython tests to run on Travis here: https://travis-ci.org/falconry/falcon/jobs/58451945. Bad news is that this involved running the Jython tests separately from tox -- so, future changes that are jython-incompatible would break Travis build, but it breaks the uniformity of how version support is tested. I dug into why tox won't run with Jython 2.7. The issue (obscured through many layers) is that, on startup, tox tries to get the version info for each python interpreter. It spins off a subprocess and basically runs Concluding thoughts: |
|
Looks like someone beat me to the bug by a few hours. http://bugs.jython.org/issue2325 |
csojinb
force-pushed
the
jython_support
branch
2 times, most recently
from
1e78057
to
336059e
Compare
Does not appear to require any changes to the actual library code, only to the tests Jython 2.7 does not have virtualenv support yet, so it can't play with tox. Once that support comes through, .travis.yml should be able to be returned to its former elegance - Ignore Jython py.class files - Run tests with Jython on Travis - Use threading instead of multiprocessing, because Jython does not have a multiprocessing module - Fix utf encoding specification - Apparently Jython is more finicky about the formatting of this - Accommodate Java time precision in middleware tests - Java does not do timestamps with better than ms precision Closes falconry#458
|
@kgriffs I think this is ready to go, pending review |
|
LGTM |
|
👍 |
feat(general): support Jython 2.7rc2
Trying to see if I can get the tests to run with Jython on Travis. Haven't actually implemented Jython support fixes yet.All tests run for me locally, now, except for coverage, which is not compatible with Jython.Fixes #458
make Jython tests run with toxlooks like there are still problems with support for virtualenv