fix(testing.base.TestBase): parameterize api and srmock

[swizzard]

Make api and srmock arguments to TestBase.setUp

As currently implemented, API and testing.srmock.StartResponseMock
objects are instantiated during setUp. This means subclasses either
need to throw away those instances, or eschew the super call.

[sriram-mv]

Looks good to me.

[kgriffs]

Nitpick: It's a good habit to explicitly test for None (e.g., falcon.API() if api is None else api) since the object being passed in may (unexpectedly) evaluate to False, but in this case I don't think it matters since we are expecting instances of API and StartResponseMock which are known to always evaluate to True.

[kgriffs]

@swizzard Just a couple suggestions inline. Otherwise, could you please rebase onto master and squash down to a single commit? Thanks!

[philiptzou]

I'd like to propose a new design here which I learned this trick first from Flask:

class TestBase(unittest.TestCase):
    api_class = falcon.API
    srmock_class = StartResponseMock

    def setUp(self):
        # blah blah
        self.api = self.api_class()
        self.srmock = self.srmock_class()
        # other blah blah

I perceive that super() call is also ugly since you had to override the whole setUp method actually. But override class attributes are much smooth and looks more "Pythonic" to me.

[kgriffs]

@philiptzou's We're actually already using this strategy in falcon.Request to determine the type of the context attribute. I've seen it work well in a few other projects, assuming it's well-documented.

@swizzard What do you think?

[swizzard]

I implemented @philiptzou's fix. I usually just let my agonized, flailing git logs speak for themselves, so if I've messed something up on the rebase, please let me know.

[philiptzou]

self.api = self.api_class()

[kgriffs]

LGTM, thanks!