Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): Don't double-encode percent-encoded URIs #869

Merged
merged 1 commit into from
Aug 27, 2016

Conversation

kgriffs
Copy link
Member

@kgriffs kgriffs commented Aug 16, 2016

Detect a URI that is already encoded, and don't re-encode in that case.

Fixes #687

@codecov-io
Copy link

codecov-io commented Aug 16, 2016

Current coverage is 100% (diff: 100%)

Merging #869 into master will not change coverage

@@           master   #869   diff @@
====================================
  Files          30     30          
  Lines        1875   1885    +10   
  Methods         0      0          
  Messages        0      0          
  Branches      305    309     +4   
====================================
+ Hits         1875   1885    +10   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update e0f0593...0faf125

@kgriffs
Copy link
Member Author

kgriffs commented Aug 23, 2016

[rebased]

@kgriffs
Copy link
Member Author

kgriffs commented Aug 25, 2016

[rebased]

Detect a URI that is already encoded, and don't re-encode in that
case.

Fixes falconry#687
@fxfitz
Copy link
Contributor

fxfitz commented Aug 26, 2016

LGTM

@jmvrbanac
Copy link
Member

👍

@jmvrbanac jmvrbanac merged commit e0ce4e9 into falconry:master Aug 27, 2016
@kgriffs kgriffs deleted the issues-687-double-encode branch August 27, 2016 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants