New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for closing filelike response stream objects #961
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
de20755
Fixes #960 - Add support for closing response streams.
6c34f7f
Refs #960 - Remove commented out code.
299f7a2
Merge branch 'master' into master
kgriffs 2b7d6c4
Merge branch 'master' into master
kgriffs ed88a70
Merge branch 'master' into master
kgriffs 5976d78
Refs #960 - Doc tweaks and py2 test fix.
hozn 9e08a66
Tweak the docstring, add newline at EOF
kgriffs ad0aad7
Merge branch 'master' into master
kgriffs 1f2ec31
fix: Single newline with no other whitespace at EOF
kgriffs aa8f7af
fix(pep8): Remove trailing whitespace
kgriffs b808510
test(CloseableStreamIterator): Cover callable branch
kgriffs 0ec3191
doc(CloseableStreamIterator): Move "args" section into the class docs…
kgriffs File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Would you mind reformatting this according to PEP-257?
E.g.:
Also, it may be helpful to mention why a "closeable" iterator is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do.