Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate from travis ci to github workflows #112

Merged
merged 1 commit into from Aug 7, 2023
Merged

ci: migrate from travis ci to github workflows #112

merged 1 commit into from Aug 7, 2023

Conversation

jpvanhal
Copy link
Member

@jpvanhal jpvanhal commented Aug 6, 2023

Migrate from Travis CI to Github workflows in order to have a working CI again. A few notes about the changes:

  • Python 3.6 is no longer tested because it's not available for Ubuntu 22.04 and it's no longer supported.

  • There were a few too long lines which prevented the linting job from passing. These were fixed.

  • The postgres service used in the Github workflow requires a password, so the tests were modified to make providing custom credentials possible.

  • In tox.ini, the sqla1.4 factor dependency did not have an upper version limit, so it was installing SQLAlchemy 2.0 instead of SQLAlchemy 1.4. The lint factor was installing a too recent isort version.

Migrate from Travis CI to Github workflows in order to have a working CI
again. A few notes about the changes:

- Python 3.6 is no longer tested because it's not available for Ubuntu
  22.04 and it's [no longer supported](https://endoflife.date/python).

- There were a few too long lines which prevented the linting job from
  passing. These were fixed.

- The `postgres` service used in the Github workflow requires a
  password, so the tests were modified to make providing custom
  credentials possible.

- In `tox.ini`, the `sqla1.4` factor dependency did not have an upper
  version limit, so it was installing SQLAlchemy 2.0 instead of
  SQLAlchemy 1.4. The `lint` factor was installing a too recent isort
  version.
@jpvanhal jpvanhal merged commit 6b0296d into falcony-io:master Aug 7, 2023
@jpvanhal jpvanhal deleted the github-actions branch August 7, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant