test: rewrite test suite to use pytest fixtures #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the test suite to use pytest fixtures ove classic xunit-style set-up. The fixture mechanism is more powerful and allows more modular and scalable approach for managing test state. The tests for `sync_trigger()` and `drop_trigger()` were previously parametrized with `create_test_cases()` function to test the various `search_trigger_name` and `search_trigger_function_name` combinations. This did not have any effect because the tests were not passing them as `options` parameter to `sync_trigger()` and `drop_trigger()` functions. This is now fixed. The `Order` model was removed from the tests. It was not used by any test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the test suite to use pytest fixtures ove classic xunit-style set-up. The fixture mechanism is more powerful and allows more modular and scalable approach for managing test state.
The tests for
sync_trigger()anddrop_trigger()were previously parametrized withcreate_test_cases()function to test the varioussearch_trigger_nameandsearch_trigger_function_namecombinations. This did not have any effect because the tests were not passing them asoptionsparameter tosync_trigger()anddrop_trigger()functions. This is now fixed.The
Ordermodel was removed from the tests. It was not used by any test case.