Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falco): reintroduce service account #613

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Feb 5, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

This PR reintroduces the service account removed in the previous release. see #612

Which issue(s) this PR fixes:
#612

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped labels Feb 5, 2024
@poiana poiana requested review from bencer and cpanato February 5, 2024 16:34
@poiana poiana added the size/M label Feb 5, 2024
charts/falco/Chart.yaml Outdated Show resolved Hide resolved
charts/falco/templates/pod-template.tpl Show resolved Hide resolved
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@alacuku
Copy link
Member Author

alacuku commented Feb 6, 2024

Hey @cpanato, could you please have a look?

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks

@poiana poiana added the lgtm label Feb 6, 2024
@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

LGTM label has been added.

Git tree hash: 40514740b863b5b664c8d9bb5db56baf225a9235

@poiana poiana added the approved label Feb 6, 2024
@poiana poiana merged commit 53e41ca into falcosecurity:master Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants