Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter): update tolerations #614

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Feb 6, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Update the tolerations.

Which issue(s) this PR fixes:

Fixes #
#579
Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falco-exporter-chart labels Feb 6, 2024
@poiana poiana requested review from bencer and cpanato February 6, 2024 08:49
@poiana poiana added the size/S label Feb 6, 2024
cpanato
cpanato previously approved these changes Feb 6, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
cpanato
cpanato previously approved these changes Feb 6, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Feb 6, 2024
@cpanato
Copy link
Member

cpanato commented Feb 6, 2024

humm just saw the tests are failing

/lgtm cancel

@poiana poiana removed the lgtm label Feb 6, 2024
@poiana poiana requested a review from cpanato February 6, 2024 10:04
@poiana poiana removed the approved label Feb 6, 2024
@alacuku
Copy link
Member Author

alacuku commented Feb 6, 2024

For some reason the connection test is failing. It seems that the wget container is started before the falco exporter pods are ready.
By running the same test manually after the falco-exporte pods are ready everything works fine.

@cpanato any idea why this is happening?

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@alacuku
Copy link
Member Author

alacuku commented Feb 6, 2024

@cpanato
Helm v3.10 was not honoring the --wait & --timeout flags. Bumped to v3.14.0. Solved the issue.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Feb 6, 2024
@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

LGTM label has been added.

Git tree hash: 0c0ccf91d4d521e472a42d07fa9c974e662b89a6

@poiana
Copy link
Contributor

poiana commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Feb 6, 2024
@poiana poiana merged commit c1fb1da into falcosecurity:master Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-exporter-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants