use directory-mapping instead of simple containerd.socket-file-mapping

[devfaz]

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falco-chart

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #632

Special notes for your reviewer:

to allow falco to reconnect if containerd got restarted on host

Checklist

• Chart Version bumped
• Variables are documented in the README.md
• CHANGELOG.md updated

[poiana]

Welcome @devfaz! It looks like this is your first PR to falcosecurity/charts 🎉

[alacuku]

Hi @devfaz, thank you for the PR!

Could you please update the docs by running make docs?

[devfaz]

Hi @devfaz, thank you for the PR!

Could you please update the docs by running make docs?

run make docs but it didnt generate any change.

[alacuku]

Hi @devfaz, thank you for the PR!
Could you please update the docs by running make docs?

run make docs but it didnt generate any change.

Running make docs on your branch:

diff --git a/charts/falco/README.md b/charts/falco/README.md
index e83c3f5..81ecd66 100644
--- a/charts/falco/README.md
+++ b/charts/falco/README.md
@@ -581,7 +581,7 @@ If you use a Proxy in your cluster, the requests between `Falco` and `Falcosidek
 
 ## Configuration
 
-The following table lists the main configurable parameters of the falco chart v4.2.2 and their default values. See [values.yaml](./values.yaml) for full list.
+The following table lists the main configurable parameters of the falco chart v4.2.3 and their default values. See [values.yaml](./values.yaml) for full list.

[devfaz]

im using podman, so had to adapt the Makefile a bit to get it working. Just a FYI in case someone googles this later.

diff --git a/Makefile b/Makefile
index 86f6097..621c855 100644
--- a/Makefile
+++ b/Makefile
@@ -29,6 +29,7 @@ docs-%:
        --rm \
        --workdir=/helm-docs \
        --volume "$$(pwd):/helm-docs" \
+       --userns=keep-id:uid=$$(id -u),gid=$$(id -g) \
        -u $$(id -u) \
        jnorwood/helm-docs:$(DOCS_IMAGE_VERSION) \
        helm-docs -c ./charts/$* -t ./README.gotmpl -o ./README.md

[poiana]

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

[devfaz]

/remove-lifecycle stale

[alacuku]

@devfaz, do you plan to update this PR by any chance?

[devfaz]

@alacuku I already did? Do you miss anything?

[alacuku]

You need to rebase and resolve the conflicts.

[devfaz]

You need to rebase and resolve the conflicts.

Done, sorry havnt seen it.

@alacuku

[alacuku]

/lgtm

[poiana]

LGTM label has been added.

Git tree hash: a1483f69a6ffb4fef0da57099b2b45a9d9a44a6f

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, devfaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alacuku]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment