The sidekick chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
|
Welcome @kwop! It looks like this is your first PR to falcosecurity/charts 🎉 |
kwop
changed the title
kwop
changed the title
|
Thanks for this fix, can you squash your commits please, I enabled the CI, all checks are ok. |
|
Can you rebase on the master and fix the conflicts, please |
Prometheus does not accept duplicate rule name. The chart rule can't be installed. Signed-off-by: Belazar Mohamed <50041651+kwop@users.noreply.github.com> Update Chart.yaml Bump chart version Signed-off-by: Belazar Mohamed <50041651+kwop@users.noreply.github.com> Update CHANGELOG.md Signed-off-by: Belazar Mohamed <50041651+kwop@users.noreply.github.com> Fix PrometheusRule duplicate alert name
Issif
approved these changes
Apr 30, 2024
|
LGTM label has been added. Git tree hash: ba890ffd1dab5f0c99c44f5b5eb021db3e9cf6bd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, kwop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
/kind chart-release
/area falcosidekick-chart
Prometheus does not accept duplicate rule name.
The chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created.