Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add extra labeling capabilities for falco daemonset/deployment #684

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Strigix
Copy link
Contributor

@Strigix Strigix commented Jun 6, 2024

/kind feature

/kind chart-release

/area falco-chart

What this PR does / why we need it:

This PR adds an extra field: controller.labels which allows users to set extra labels for the Falco daemonset/deployment.

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: no kind/chart-release Add this label when the chart version has been bumped area/falco-chart labels Jun 6, 2024
@poiana
Copy link
Contributor

poiana commented Jun 6, 2024

Welcome @Strigix! It looks like this is your first PR to falcosecurity/charts 🎉

charts/falco/values.yaml Outdated Show resolved Hide resolved
@alacuku
Copy link
Member

alacuku commented Jun 10, 2024

Please, run make docs to update the docs.

@alacuku
Copy link
Member

alacuku commented Jun 17, 2024

@Strigix, can you bump the chart version and then run make docs? It should make the CI happy.

@Strigix
Copy link
Contributor Author

Strigix commented Jun 17, 2024

@alacuku I Hadn't realised it went up another version!
Bumped and reran make docs :) Thanks for the headsup.

charts/falco/CHANGELOG.md Outdated Show resolved Hide resolved
@Strigix Strigix requested a review from alacuku June 17, 2024 12:16
@alacuku
Copy link
Member

alacuku commented Jun 17, 2024

hey @Strigix, could you squash your commits? Once you've done it, we are ready to merge it.

@Strigix Strigix force-pushed the master branch 2 times, most recently from d898fbd to 75613fd Compare June 18, 2024 10:47
…ing.

Signed-off-by: Strigix <stefan@vtveld.nl>
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Strigix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 18, 2024

LGTM label has been added.

Git tree hash: eabfb6f77a0cc5479ec54e77707f10337fe5f69e

@poiana poiana merged commit 040aea0 into falcosecurity:master Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants