Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong WEBUI_URL since #685 #687

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

Sryther
Copy link
Contributor

@Sryther Sryther commented Jun 11, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Wrong WEBUI_URL value since #685.

Example:

# helm template -s templates/secrets.yaml . | yq '.data.WEBUI_URL|@base64d'
http://release-name-falcosidekick-ui:%!s(float64=2802)

Should be:

# helm template -s templates/secrets.yaml . | yq '.data.WEBUI_URL|@base64d'
http://release-name-falcosidekick-ui:2802

Which issue(s) this PR fixes:

Fixes #686

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Signed-off-by: Paul Rey <contact@paulrey.io>
Signed-off-by: Paul Rey <contact@paulrey.io>
Signed-off-by: Paul Rey <contact@paulrey.io>
@poiana poiana requested review from alacuku and bencer June 11, 2024 11:45
@poiana poiana added the size/XS label Jun 11, 2024
@Sryther Sryther changed the title Fixes #686 Fix wrong WEBUI_URL since #685 Jun 11, 2024
@poiana
Copy link
Contributor

poiana commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, Sryther

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 11, 2024

LGTM label has been added.

Git tree hash: 5484eccba593a6e7200d377b0b62b806b9414f49

@poiana poiana merged commit d9c3ff9 into falcosecurity:master Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

falcosidekick: WEBUI_URL - port incorrectly rendered as float64
3 participants