Update securitycontextconstraints.yaml #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
|
Welcome @toamto94! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
Thanks @toamto94, To be valid, your changes must come with a bump of the chart version and an update of changelog. |
poiana
added
dco-signoff: no
do-not-merge/contains-merge-commits
size/S
and removed
dco-signoff: yes
size/XS
labels
toamto94
force-pushed
the
fb_toamto94-patch-scc-v2
branch
from
b8aac65
to
f4d1453
Compare
poiana
added
dco-signoff: yes
dco-signoff: no
and removed
dco-signoff: no
do-not-merge/contains-merge-commits
dco-signoff: yes
labels
toamto94
force-pushed
the
fb_toamto94-patch-scc-v2
branch
from
c731c20
to
49bf203
Compare
toamto94
force-pushed
the
fb_toamto94-patch-scc-v2
branch
2 times, most recently
from
2f96781
to
4e51a83
Compare
|
changelog and chart bump has been added |
|
Hey @toamto94, could you update the docs by running |
Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
toamto94
force-pushed
the
fb_toamto94-patch-scc-v2
branch
from
4e51a83
to
ecbf577
Compare
done :) |
|
LGTM label has been added. Git tree hash: 5fa9ff93775c6499a0c67203122a24f32e78b3d0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, toamto94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ordered volume list in falco scc yaml alphabetically
What type of PR is this?
/kind bug
/kind chart-release
/area falco-chart
What this PR does / why we need it:
Making the helm chart more robust by re-ordering configuration in the falco helm chart scc yaml
Which issue(s) this PR fixes:
Sync errors in ArgoCD as a result of the unordered list which is ordered by the kube-api alphabetically. Argo then compares plain yaml and fails
Fixes #693
Special notes for your reviewer:
Checklist