test(pkg/generate): ensure configurations are generated

Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
falcosecurity · Sep 26, 2023 · ef0b165 · ef0b165
1 parent a689ae7
commit ef0b165
Showing 1 changed file with 78 additions and 15 deletions.
diff --git a/pkg/generate/generate_test.go b/pkg/generate/generate_test.go
@@ -1,12 +1,14 @@
 package generate
 
 import (
+	"os"
+	"testing"
+
 	"github.com/falcosecurity/dbg-go/pkg/root"
+	"github.com/falcosecurity/dbg-go/pkg/stats"
 	testutils "github.com/falcosecurity/dbg-go/pkg/utils/test"
 	"github.com/falcosecurity/dbg-go/pkg/validate"
 	"github.com/stretchr/testify/assert"
-	"os"
-	"testing"
 )
 
 func BenchmarkAutogenerate(b *testing.B) {
@@ -33,8 +35,9 @@ func BenchmarkAutogenerate(b *testing.B) {
 func TestGenerate(t *testing.T) {
 	testCacheData = true // enable json data caching for subsequent tests
 	tests := map[string]struct {
-		opts        Options
-		expectError bool
+		opts               Options
+		expectError        bool
+		expectedMinConfigs int
 	}{
 		"run in auto mode with loaded from kernel-crawler distro on multiple driver versions": {
 			opts: Options{
@@ -49,7 +52,8 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 		"run in auto mode with any target distro filter on single driver version": {
 			opts: Options{
@@ -61,7 +65,8 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 		"run in auto mode with target distro filter on single driver version": {
 			opts: Options{
@@ -76,7 +81,8 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 		"run in auto mode with non existent target distro on single driver version": {
 			opts: Options{
@@ -91,7 +97,8 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false, // we do not expect any error; no configs will be generated though
+			expectError:        false, // we do not expect any error; no configs will be generated though
+			expectedMinConfigs: 0,
 		},
 		"run in auto mode with single target distro on single driver version with custom driver name": {
 			opts: Options{
@@ -106,7 +113,43 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
+		},
+		"run in auto mode with single target distro with regex kernel version on single driver version": {
+			opts: Options{
+				Options: root.Options{
+					RepoRoot:      "./test/",
+					Architecture:  "amd64",
+					DriverVersion: []string{"1.0.0+driver"},
+					Target: root.Target{
+						Distro:        "centos",
+						KernelVersion: "^1$",
+					},
+					DriverName: "falco",
+				},
+				Auto: true,
+			},
+			expectError:        false,
+			expectedMinConfigs: 1,
+		},
+		"run in auto mode with single target distro with regex kernel release on single driver version": {
+			opts: Options{
+				Options: root.Options{
+					RepoRoot:      "./test/",
+					Architecture:  "amd64",
+					DriverVersion: []string{"1.0.0+driver"},
+					Target: root.Target{
+						Distro:        "centos",
+						KernelRelease: `^5\..+$`,
+						KernelVersion: "1",
+					},
+					DriverName: "falco",
+				},
+				Auto: true,
+			},
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 		"run in auto mode with regex target distro on single driver version with custom driver name": {
 			opts: Options{
@@ -121,7 +164,8 @@ func TestGenerate(t *testing.T) {
 				},
 				Auto: true,
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 		"run with empty target kernel release on single driver version": {
 			opts: Options{
@@ -136,7 +180,8 @@ func TestGenerate(t *testing.T) {
 					DriverName: "falco",
 				},
 			},
-			expectError: true,
+			expectError:        true,
+			expectedMinConfigs: 1,
 		},
 		"run with empty target kernel version on single driver version": {
 			opts: Options{
@@ -151,7 +196,8 @@ func TestGenerate(t *testing.T) {
 					DriverName: "falco",
 				},
 			},
-			expectError: true,
+			expectError:        true,
+			expectedMinConfigs: 1,
 		},
 		"run with empty target distro on single driver version": {
 			opts: Options{
@@ -166,7 +212,8 @@ func TestGenerate(t *testing.T) {
 					DriverName: "falco",
 				},
 			},
-			expectError: true,
+			expectError:        true,
+			expectedMinConfigs: 1,
 		},
 		"run with unsupported target distro on single driver version": {
 			opts: Options{
@@ -182,7 +229,8 @@ func TestGenerate(t *testing.T) {
 					DriverName: "falco",
 				},
 			},
-			expectError: true,
+			expectError:        true,
+			expectedMinConfigs: 0,
 		},
 		// NOTE: the below test is flaky: if debian pulls down the headers, we will break.
 		// in case, just update to a newer version.
@@ -200,7 +248,8 @@ func TestGenerate(t *testing.T) {
 					DriverName: "falco",
 				},
 			},
-			expectError: false,
+			expectError:        false,
+			expectedMinConfigs: 1,
 		},
 	}
 
@@ -216,6 +265,20 @@ func TestGenerate(t *testing.T) {
 				assert.Error(t, err)
 			} else {
 				assert.NoError(t, err)
+
+				// Ensure configs are generated.
+				statter := stats.NewFileStatter()
+
+				// Get stats on generated configurations for all kernels and distros.
+				statsOpts := test.opts.Options
+				statsOpts.KernelVersion = ""
+				statsOpts.KernelRelease = ""
+				statsOpts.Distro = ""
+
+				stats, err := statter.GetDriverStats(statsOpts)
+				assert.NoError(t, err)
+				assert.GreaterOrEqual(t, len(stats), test.expectedMinConfigs)
+
 				// Validate all generated files
 				validateOpts := validate.Options{Options: test.opts.Options}
 				if validateOpts.Distro == "load" {