Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSE Linux Enterprise Support #304

Merged
merged 2 commits into from Nov 13, 2023

Conversation

EXONER4TED
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:

Adds initial support for SUSE Linux Enterprise. It's much like RHEL, will require a --builderimage with authentication setup, but it does allow the user the ability to bring-your-own-container and build.

Example:

scwx-sles12-sp5:~/driverkit # ~/driverkit/_output/bin/driverkit docker --kernelrelease 4.12.14-122.7.1 --kernelversion 1 --target sle --output-module ./test.ko --builderimage sle-builder:latest
level=INFO msg="driver building, it will take a few seconds" processor=docker
level=INFO msg="kernel module available" path=./test.ko

An example of a hacked-together Dockerfile used for the above build:

FROM registry.suse.com/suse/sles12sp5

COPY credentials/* /etc/zypp/credentials.d/

RUN zypper ref -s && zypper install -y SUSEConnect && SUSEConnect -p sle-module-toolchain/12/x86_64

RUN zypper ref && zypper --non-interactive install \
	make  \
	gcc   \
	tar   \
	gzip  \
	curl  \
	gcc8  \
	kmod && \
    ln -s /usr/bin/gcc-8 /usr/bin/gcc-8.0.0

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for your reviewer:

Crawling for SLES/D kernels should be relatively easy as well, using the same sort of strategy as RHEL with an authenticated container. I'll be making a PR to kernel-crawler as well.

Does this PR introduce a user-facing change?:

Adds SUSE Linux Enterprise support

Signed-off-by: Logan Bond <logantbond@gmail.com>
Signed-off-by: Logan Bond <logantbond@gmail.com>
@poiana poiana added kind/feature New feature or request dco-signoff: yes area/build Further information is requested labels Nov 10, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 13, 2023

LGTM label has been added.

Git tree hash: 6e2c4f2c0b44a320449a74d6f4b033fb08e95ce7

@poiana poiana merged commit 67451e4 into falcosecurity:master Nov 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build Further information is requested dco-signoff: yes kind/feature New feature or request lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants