Restyle the Kubernetes manifests structure #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename the solution directories, restyle the directory structure since the solutions are not properly integrations but unofficial deployment methods for falco Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
leogr
approved these changes
May 16, 2020
|
LGTM label has been added. Git tree hash: 399d48377c594ab60041072f6802eb34682458d1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would rename the on top of Kubenetes deploy solutions' directories and I would refactor the directories structure itself because in my opinion the solutions are not properly integrations but instead unofficial deployment methods for Falco (for example
anchore-falcocould be considerated properly an integration with Falco).I don't know if we'd want keep this PR within the rename of the repository discussion, but I think that this PR can proceed autonomously since it could end up being integrated inside the
/contribdirectory.WDYT? :)