Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/k8s audit endpoint #31

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Update/k8s audit endpoint #31

merged 3 commits into from
Jun 17, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 15, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind feature

/kind sandbox

/kind incubating

/kind officialsupport

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area deploy

/area examples

/area integrations

/area proposals

What this PR does / why we need it:

As per falcosecurity/falco#1261

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@leogr
update(deploy/kubernetes): correct k8s audit endpoint
3154d5c 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(examples): correct k8s audit endpoint
b07c84c 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(integrations): correct k8s audit endpoint
d092901 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr requested a review from maxgio92 June 15, 2020 16:41
@poiana poiana requested a review from fntlnz June 15, 2020 16:43
@poiana poiana added size/XS and removed needs-kind labels Jun 15, 2020
maxgio92
maxgio92 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@maxgio92 maxgio92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maxgio92 maxgio92 added the lgtm label Jun 17, 2020
@poiana
Copy link
Contributor

poiana commented Jun 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0c733c4 into master Jun 17, 2020
@poiana poiana deleted the update/k8s-audit-endpoint branch June 17, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgio92 maxgio92 maxgio92 approved these changes

@fntlnz fntlnz Awaiting requested review from fntlnz

Assignees

@maxgio92 maxgio92

Labels
approved dco-signoff: yes kind/bug Something isn't working kind/sandbox lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leogr @poiana @maxgio92