Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions to run integration test locally #227

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Jul 15, 2020

What type of PR is this?

/kind content

/kind translation

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

This PR updates the docs as per falcosecurity/falco#1313

Which issue(s) this PR fixes:

Refs falcosecurity/falco#1312

Special notes for your reviewer:

/hold

Hold this PR until falcosecurity/falco#1313 is merged into Falco.

… locally

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…ration tests locally

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana added size/S and removed size/XS labels Jul 15, 2020
@leodido
Copy link
Member Author

leodido commented Jul 15, 2020

@TakaoShimizu I'd love if you could help me with the Japanese updates! 🥰

@TakaoShimizu
Copy link
Contributor

TakaoShimizu commented Jul 16, 2020

Falco.org updated for several documents. I will review all of English documents and update Japanese documents. :-)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Jul 16, 2020

LGTM label has been added.

Git tree hash: 700a3b92da09ea96f5c3945f975b1b4f347ae150

@poiana
Copy link

poiana commented Jul 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Jul 21, 2020

/hold cancel

@poiana poiana merged commit 053371d into master Jul 21, 2020
@poiana poiana deleted the update/integration-tests-instructions branch July 21, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants