Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor integration images #1012

Merged
merged 12 commits into from
Jan 23, 2020
Merged

Refactor integration images #1012

merged 12 commits into from
Jan 23, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jan 23, 2020 •
edited
Loading

ATTENTION: this is blocking all the incoming PRs because we have a problem with the current tester image.

What type of PR is this?

/kind failing-test

Any specific area of the project related to this PR?

/area build
/area tests

What this PR does / why we need it:

Does two things:

  • Introduces a new framework to run tests from packages directly in containers, one can add more instructions to the entrypoint to test to more different distributions
  • Fixes the recent problems in building using the docker local image that was lacking the binutils dependency (and that was not needed for the tests)

Which issue(s) this PR fixes:

Fixes #1013

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

test: integration tests now can run on different distributions via docker containers, for now CentOS 7 and Ubuntu 18.04 with respective rpm and deb packages

fntlnz and others added 7 commits January 23, 2020 12:01
@fntlnz @leodido
update(integration): switch to docker runners for packages
d33970e 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
new(integration): docker deb runner
e5c740d 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
update(integration): falco tester entrypoint
53c07df 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
update(integration): mount rules and traces paths in falco_test.py
7747790 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
update(integration): rpm tester docker image
2495fcf 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
chore(circleci): temporary config for falco tester image
f40c0ea 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
chore(integration): add dkms to docker test deb runner
1d1878a 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana poiana requested review from krisnova and mfdii January 23, 2020 11:15
@poiana poiana added the size/L label Jan 23, 2020
@fntlnz @leodido
chore(integration): libyaml in tester docker file for deb packages
096ed6e 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the feat/integration-refactor-images branch from 4c06c56 to 096ed6e Compare January 23, 2020 11:18
@fntlnz fntlnz changed the title Feat/integration refactor images Refactor integration images Jan 23, 2020
@fntlnz
Copy link
Contributor Author

fntlnz commented Jan 23, 2020

/cc @leodido

@poiana poiana requested a review from leodido January 23, 2020 11:20
@leodido @fntlnz
chore: cleanup docker test runners
598da2b 
Co-Authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido and others added 3 commits January 23, 2020 13:36
@leodido @fntlnz
fix(docker/tester): falco-tester does not have to check for docker/lo…
0088ef0 
…cal anymore

Co-Authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
fix(docker/tester): share rules and trace files with docker test runners
336b215 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
chore: use latest falco-tester again
3785509 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido force-pushed the feat/integration-refactor-images branch from d5b0d86 to 3785509 Compare January 23, 2020 13:37
leodido
leodido approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@poiana poiana added the lgtm label Jan 23, 2020
@poiana
Copy link

poiana commented Jan 23, 2020

LGTM label has been added.

Git tree hash: 52118f53651746e6984f580da4e83f31e9113078

@poiana
Copy link

poiana commented Jan 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 725f16b into dev Jan 23, 2020
@poiana poiana deleted the feat/integration-refactor-images branch January 23, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido approved these changes

@krisnova krisnova Awaiting requested review from krisnova

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@leodido leodido

Labels
approved area/build dco-signoff: yes kind/failing-test lgtm release-note size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

falco-tester is failing to build docker/local inner docker image
3 participants
@fntlnz @poiana @leodido