Support for Kubernetes >= 1.16 #1044

maxgio92 · 2020-02-09T19:02:30Z

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area kubernetes

What this PR does / why we need it:

Support for Kubernetes 1.16 and 1.17 when deployed as DaemonSet.

Which issue(s) this PR fixes:

Fixes #1043
Fixes #993

Special notes for your reviewer:

Removed deprecated Kubernetes 1.16 API resource versions.

Affected API:

DaemonSet
Deployment
ClusterRole
ClusterRoleBinding

Documentation:

Does this PR introduce a user-facing change?:

NONE

Release note

docs(integrations): update API resource versions to Kubernetes 1.16

poiana · 2020-02-09T19:02:44Z

Welcome @maxgio92! It looks like this is your first PR to falcosecurity/falco 🎉

maxgio92 · 2020-02-09T19:11:11Z

Thanks @poiana!
/assign @leodido

krisnova

Thank you! This was annoying me also.

poiana · 2020-02-11T20:58:50Z

LGTM label has been added.

Git tree hash: df61ca37e4037f2f0fcd25c5e6d9d97692b6b407

krisnova · 2020-02-12T03:40:06Z

/hold

The more I think about this the more I think we need to have this new chart in a different directory so that we can support both

maxgio92 · 2020-02-12T11:52:33Z

/hold

The more I think about this the more I think we need to have this new chart in a different directory so that we can support both

Thanks @kris-nova. Are you referrring to Kubernetes >= 1.16 and Kubernetes < 1.16?

leodido · 2020-02-25T12:26:08Z

/milestone 0.21.0

fntlnz · 2020-03-05T12:59:08Z

Let me remove this from the milestone until we don't have a clear idea of how we want to do those. Also the integrations folder is not tied to a particular Falco release so we can do this whenever without a specific release for it. :)

fntlnz · 2020-03-08T14:37:32Z

@kris-nova do you want to hold this still? We might just ask @maxgio92 to create a different directory for this?

fntlnz · 2020-03-08T14:40:22Z

The change was already merged in the helm chart helm/charts#17339

leodido · 2020-03-12T14:29:38Z

@leogr this is the PR I was mentioning to you before

leogr · 2020-03-12T14:43:19Z

The change was already merged in the helm chart helm/charts#17339

Just an idea: we could automate this by using the helm chart to locally render the templates for each supported configuration. @leodido @fntlnz WDYT?

fntlnz · 2020-04-14T10:38:33Z

I think we can merge this and then have a discussion on how/where to keep manifests for old Kubernetes versions.

Also from the release announcement:

DaemonSet in the extensions/v1beta1 and apps/v1beta2 API versions is no longer served

    Migrate to use the apps/v1 API version, available since v1.9. Existing persisted data can be retrieved/updated via the new version.
    Notable changes:
        spec.templateGeneration is removed
        spec.selector is now required and immutable after creation; use the existing template labels as the selector for seamless upgrades
        spec.updateStrategy.type now defaults to RollingUpdate (the default in extensions/v1beta1 was OnDelete)

leodido

Hey @maxgio92 we decided to merge this as soon the last changes requested by me and @fntlnz are committed.

In particular, this PR must also include the changes to replace deployment extensions/v1beta1 to apps/v1

integrations/k8s-using-deployment/k8s-with-rbac/falco-k8s-audit-deployment.yaml
1:apiVersion: extensions/v1beta1
integrations/k8s-using-deployment/falco-event-generator-deployment.yaml
1:apiVersion: extensions/v1beta1

Finally, we'd like help in maintaining these files (maybe for different K8S versions too). In case you're interested in helping us with this topic please join the next community call to make a plan together! :)

update API resource version and remove deprecated one. Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

…version replace extension/v1beta1 with 1.16-supported apps/v1 version as for release announcement BREAKING CHANGE: spec.rollbackTo is removed, spec.selector is now required and immutable after creation, spec.progressDeadlineSeconds now defaults to 600 seconds, spec.revisionHistoryLimit now defaults to 10, maxSurge and maxUnavailable now default to 25% issue #1043 Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

replace rbac.authorization.k8s.io/v1beta1 with rbac.authorization.k8s.io/v1 as for the changelog Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

maxgio92 · 2020-04-14T17:06:58Z

Thanks @leodido @fntlnz you're right, I only checked for the resources in the daemonset solution.
Now the manifests should be correct also for the deployment solution.

Why not? :) Sure!

maxgio92 · 2020-04-14T17:24:12Z

PS: I think that it depends on the level of automation in the whole project, but as for the installation steps other than Helm charts Kustomizations could be a starting point, with overlays for each main "breaking version", as it is integrated and minimal :)

poiana · 2020-04-15T09:13:41Z

LGTM label has been added.

Git tree hash: 816f9ae80c2477ff3183138bdb08264d63749a3a

leogr

IMHO, we can now merge this, then 👉 #1145

poiana · 2020-04-16T09:55:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

leodido · 2020-04-16T10:34:10Z

/hold cancel

poiana added kind/feature dco-signoff: yes labels Feb 9, 2020

poiana requested review from mfdii and mstemm February 9, 2020 19:02

poiana added the do-not-merge/release-note-label-needed label Feb 9, 2020

poiana added the size/S label Feb 9, 2020

poiana assigned leodido Feb 9, 2020

krisnova previously approved these changes Feb 11, 2020

View reviewed changes

poiana assigned krisnova Feb 11, 2020

poiana added the lgtm label Feb 11, 2020

poiana added the approved label Feb 11, 2020

poiana added the do-not-merge/hold label Feb 12, 2020

maxgio92 mentioned this pull request Feb 13, 2020

Unable to install Falco by applying DaemonSet #1043

Closed

poiana added this to the 0.21.0 milestone Feb 25, 2020

fntlnz removed this from the 0.21.0 milestone Mar 5, 2020

fntlnz mentioned this pull request Mar 5, 2020

Modifying apiVersion for daemonset and adding selectors #1005

Closed

leodido reviewed Apr 14, 2020

View reviewed changes

maxgio92 dismissed krisnova’s stale review via d3fc62a April 14, 2020 16:23

poiana added dco-signoff: no do-not-merge/contains-merge-commits size/M and removed lgtm dco-signoff: yes approved size/S labels Apr 14, 2020

Massimiliano added 2 commits April 14, 2020 18:42

feat: support k8s 1.16 when deployed as DaemonSet

cd55ad8

update API resource version and remove deprecated one. Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

feat: support k8s 1.17 when deployed as DaemonSet

f023913

update API resource version and remove deprecated one. Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

poiana removed the do-not-merge/contains-merge-commits label Apr 14, 2020

Massimiliano added 2 commits April 14, 2020 18:58

improvement(rbac): remove 1.17 deprecated rbac api group

52c1b4f

replace rbac.authorization.k8s.io/v1beta1 with rbac.authorization.k8s.io/v1 as for the changelog Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>

poiana added dco-signoff: yes and removed dco-signoff: no labels Apr 14, 2020

leodido approved these changes Apr 15, 2020

View reviewed changes

poiana added the lgtm label Apr 15, 2020

poiana added the approved label Apr 15, 2020

leogr mentioned this pull request Apr 15, 2020

Move "integrations" to another repo #1145

Closed

leogr approved these changes Apr 16, 2020

View reviewed changes

poiana assigned leogr Apr 16, 2020

poiana added release-note and removed do-not-merge/hold do-not-merge/release-note-label-needed labels Apr 16, 2020

poiana merged commit 4d18203 into falcosecurity:master Apr 16, 2020

leogr added this to the 0.22.0 milestone Apr 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Kubernetes >= 1.16 #1044

Support for Kubernetes >= 1.16 #1044

maxgio92 commented Feb 9, 2020 •

edited by leodido

Loading

poiana commented Feb 9, 2020

maxgio92 commented Feb 9, 2020

krisnova left a comment

poiana commented Feb 11, 2020

krisnova commented Feb 12, 2020

maxgio92 commented Feb 12, 2020 •

edited

Loading

leodido commented Feb 25, 2020

fntlnz commented Mar 5, 2020

fntlnz commented Mar 8, 2020

fntlnz commented Mar 8, 2020

leodido commented Mar 12, 2020

leogr commented Mar 12, 2020

fntlnz commented Apr 14, 2020 •

edited

Loading

leodido left a comment •

edited

Loading

maxgio92 commented Apr 14, 2020 •

edited

Loading

maxgio92 commented Apr 14, 2020 •

edited

Loading

poiana commented Apr 15, 2020

leogr left a comment

poiana commented Apr 16, 2020

leodido commented Apr 16, 2020

Support for Kubernetes >= 1.16 #1044

Support for Kubernetes >= 1.16 #1044

Conversation

maxgio92 commented Feb 9, 2020 • edited by leodido Loading

poiana commented Feb 9, 2020

maxgio92 commented Feb 9, 2020

krisnova left a comment

Choose a reason for hiding this comment

poiana commented Feb 11, 2020

krisnova commented Feb 12, 2020

maxgio92 commented Feb 12, 2020 • edited Loading

leodido commented Feb 25, 2020

fntlnz commented Mar 5, 2020

fntlnz commented Mar 8, 2020

fntlnz commented Mar 8, 2020

leodido commented Mar 12, 2020

leogr commented Mar 12, 2020

fntlnz commented Apr 14, 2020 • edited Loading

leodido left a comment • edited Loading

Choose a reason for hiding this comment

maxgio92 commented Apr 14, 2020 • edited Loading

maxgio92 commented Apr 14, 2020 • edited Loading

poiana commented Apr 15, 2020

leogr left a comment

Choose a reason for hiding this comment

poiana commented Apr 16, 2020

leodido commented Apr 16, 2020

maxgio92 commented Feb 9, 2020 •

edited by leodido

Loading

maxgio92 commented Feb 12, 2020 •

edited

Loading

fntlnz commented Apr 14, 2020 •

edited

Loading

leodido left a comment •

edited

Loading

maxgio92 commented Apr 14, 2020 •

edited

Loading

maxgio92 commented Apr 14, 2020 •

edited

Loading