Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BPF_PROBE and SYSDIG_BPF_PROBE to FALCO_BPF_PROBE and make the variable consistent #1050

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Rename BPF_PROBE and SYSDIG_BPF_PROBE to FALCO_BPF_PROBE and make the variable consistent #1050

merged 1 commit into from
Feb 24, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Feb 18, 2020 •
edited by leodido
Loading

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?
NONE

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1049

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

BREAKING CHANGE: the SYSDIG_BPF_PROBE environment variable is now just FALCO_BPF_PROBE (please update your systemd scripts or kubernetes deployments.

todo for the merge

  • Update the docs - done
  • Update helm charts
  • Update falcoctl here

@fntlnz
Copy link
Contributor Author

fntlnz commented Feb 18, 2020

/milestone 0.20.0

@poiana poiana added the size/S label Feb 18, 2020
@poiana poiana added this to the 0.20.0 milestone Feb 18, 2020
leodido
leodido previously approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! Thanks

LGTM

@poiana poiana added the lgtm label Feb 18, 2020
@poiana
Copy link

poiana commented Feb 18, 2020

LGTM label has been added.

Git tree hash: 3aa8ad67351f8c3597ff8b98aaea4c1641f14a19

@fntlnz
Copy link
Contributor Author

fntlnz commented Feb 18, 2020

/hold thinking more about this - BPF_PROBE is a way too generic name.
We want it to become FALCO_BPF_PROBE from now on. Will do that change all together in this PR.

@fntlnz fntlnz changed the title Probe environment set to BPF_PROBE also at load time Rename BPF_PROBE to FALCO_BPF_PROBE and make the variable consistent Feb 18, 2020
@fntlnz
fix: probe environment set to FALCO_BPF_PROBE also at load time
bc52db6 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
fntlnz added a commit to falcosecurity/falco-website that referenced this pull request Feb 18, 2020
@fntlnz
new: document the new FALCO_BPF_PROBE variable
77a94b0 
related to: falcosecurity/falco#1050
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz requested a review from leodido February 18, 2020 19:15
@fntlnz fntlnz mentioned this pull request Feb 18, 2020
Merged
fntlnz added a commit to falcosecurity/falco-website that referenced this pull request Feb 18, 2020
@fntlnz
new: document the new FALCO_BPF_PROBE variable
07a3d9d 
related to: falcosecurity/falco#1050
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz changed the title Rename BPF_PROBE to FALCO_BPF_PROBE and make the variable consistent Rename BPF_PROBE and SYSDIG_BPF_PROBE to FALCO_BPF_PROBE and make the variable consistent Feb 18, 2020
@fntlnz
Copy link
Contributor Author

fntlnz commented Feb 18, 2020

This also needs to be updated in falcoctl: https://github.com/falcosecurity/falcoctl/blob/b0d030c15ccaefb93d4a5b916f5e2e81b74a15ae/pkg/kubernetes/falco.go

leodido
leodido approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana poiana added the lgtm label Feb 20, 2020
@poiana
Copy link

poiana commented Feb 20, 2020

LGTM label has been added.

Git tree hash: 73ebe757dd4250e848e4bf224ffc7e41970ba565

@krisnova
Copy link
Contributor

LGTM

@fntlnz
Copy link
Contributor Author

fntlnz commented Feb 24, 2020

We are moving this out of 0.20.0 because it wasn't approved. Let's try for the next version!

@fntlnz fntlnz removed this from the 0.20.0 milestone Feb 24, 2020
@leodido
Copy link
Member

leodido commented Feb 24, 2020

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Feb 24, 2020
@leodido
Copy link
Member

leodido commented Feb 24, 2020

/cc @kris-nova

@poiana poiana requested a review from krisnova February 24, 2020 18:12
@leodido
Copy link
Member

leodido commented Feb 24, 2020

/cc @mstemm

@poiana poiana requested a review from mstemm February 24, 2020 18:12
krisnova
krisnova approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@krisnova krisnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mstemm
mstemm approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can push the parameterization of the probe variable into libscap itself later. For now doing it via a patch is okay with me.

@poiana
Copy link

poiana commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kris-nova, leodido, mstemm, rajibmitra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kris-nova,leodido,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor Author

fntlnz commented Feb 24, 2020

/hold cancel

@poiana poiana merged commit 802b9f7 into master Feb 24, 2020
@poiana poiana deleted the fix/probe-environment branch February 24, 2020 18:40
poiana pushed a commit to falcosecurity/falco-website that referenced this pull request Feb 24, 2020
@fntlnz @poiana
new: document the new FALCO_BPF_PROBE variable
09920e3 
related to: falcosecurity/falco#1050
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz mentioned this pull request Feb 27, 2020
Closed
@fntlnz fntlnz mentioned this pull request Mar 9, 2020
Closed
@leogr leogr mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido approved these changes

@rajibmitra rajibmitra rajibmitra approved these changes

@mstemm mstemm mstemm approved these changes

@krisnova krisnova krisnova approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@leodido leodido

@rajibmitra rajibmitra

@mstemm mstemm

@krisnova krisnova

Labels
approved dco-signoff: yes kind/bug lgtm release-note size/M
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

BPF_PROBE environment variable is not consistent
6 participants
@fntlnz @poiana @krisnova @leodido @rajibmitra @mstemm