fix: use of "tag" instead of "tags" in default rules #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicente Herrera <vicenteherrera@vicenteherrera.com>
|
/assign @Kaizhe |
|
LGTM label has been added. Git tree hash: adf9b237cca91a14bfbcc8c597a5bbb588feffdf
|
leodido
approved these changes
Mar 10, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.21.0 |
|
This fixed issue #1082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vicente Herrera vicenteherrera@vicenteherrera.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Fix rules that used wrong 'tag' keyword to use the right one, 'tags'.
Which issue(s) this PR fixes:
Some rules where using 'tag' keyword instead of valid 'tags' keyword. That prevented using tags to filter them.
Fixes #
Special notes for your reviewer:
After this change, when using command line switches -T to disable rules by certain tag, or -t to only run rules with a certain tag, a different set with more rules will match as now they are more rules correctly tagged.
Does this PR introduce a user-facing change?:
Yes