falco rule update: whitelist sysdig/agent and sysdig/falco for query … #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
requested changes
Mar 25, 2020
fntlnz
reviewed
Mar 26, 2020
There was a problem hiding this comment.
I like the idea behind this PR.
I think it needs two things before we merge it:
- Change
sysdig/falcotofalcosecurity/falco - Change the release note and the commit message to follow the convention for rules described here https://github.com/falcosecurity/falco/blob/master/CONTRIBUTING.md#rule-type
…st sysdig/agent and falcosecurity/falco for query miner domain dns Signed-off-by: kaizhe <derek0405@gmail.com>
Kaizhe
force-pushed
the
kh_whitelist-falco-query-miner-domain-dns
branch
from
e526dda
to
f40afa9
Compare
Done. Thanks! |
fntlnz
approved these changes
Mar 26, 2020
|
LGTM label has been added. Git tree hash: 3cf89a62b4690f73da1a31bd477b7290f707abe6
|
|
Thank you @Kaizhe !! |
mstemm
approved these changes
Mar 26, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…miner domain dns
Signed-off-by: kaizhe derek0405@gmail.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Though the rule is disabled by default, add
sysdig/agentandsysdig/falcointo the whitelist as they need to perform the dns query. So when the rule is enabled, it won't be noisy.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: