rule(Write below root): use pmatch to check against known root direct… #1137
Conversation
…ories Signed-off-by: kaizhe <derek0405@gmail.com>
There was a problem hiding this comment.
Lgtm. This does allow for additional exceptions, though, as the entire directory rooted for each entry in known_root_directories can be written to at arbitrary depths. I guess it's easier than trying to match the directory structure for those apps that write more than one file deep below a given directory, though.
|
LGTM label has been added. Git tree hash: e49eebc46e2174ad9c894552a595e4dd2c68c861
|
|
I agree with @mstemm however this looks like a necessary evil for now since we don't really have a way to map everything. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.22.0 |
…ories
Signed-off-by: kaizhe derek0405@gmail.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
When check against directories, we want to also check the subdirectories as well, so
inis not the best option, usepmatchinstead.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: