rule(macro user_known_set_setuid_or_setgid_bit_conditions): create macro #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro will be useful because it will make it possible to filter out events with a higher degree of granularity than is currently possible for the `Set Setuid or Setgid bit` rule. For example, if some application is expected to set the setuid or the setgid bit under a specific condition, like if it's started with a specific command, then the `user_known_chmod_applications` list is not enough because we don't want to filter out _all_ events by this application, only specific ones. This macro allows that. Signed-off-by: Nicolas Marier <nmarier@coveo.com>
|
Thanks! |
Kaizhe
approved these changes
May 19, 2020
|
LGTM label has been added. Git tree hash: 856dc2ad6d950e14a0ec355cc43ea87d29badaed
|
1 similar comment
|
LGTM label has been added. Git tree hash: 856dc2ad6d950e14a0ec355cc43ea87d29badaed
|
|
reopening to let the CI do its thing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This macro will be useful because it will make it possible to filter out
events with a higher degree of granularity than is currently possible
for the
Set Setuid or Setgid bitrule.For example, if some application is expected to set the setuid or the
setgid bit under a specific condition, like if it's started with a
specific command, then the
user_known_chmod_applicationslist is notenough because we don't want to filter out all events by this
application, only specific ones. This macro allows that.
A concrete example of this is when using docker-in-docker : the
dockerdprocess is triggering theSet Setuid or Setgid bitrule and every time it does,proc.cmdlineis the same. This is expected in our case, but we don't want to just ignore all events fromdockerdwithin this rule, just this specific one with this specificproc.cmdlinevalue.Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: