Unix socket for the gRPC server #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
The CMake module downloads `string-view-lite` from https://github.com/martinmoene/string-view-lite It is a single-file header-only version of C++17-like `string_view` for C++98, C++03, C++11, and later. Notices it also provides C++20 extensions like: - empty() - starts_with() - ends_with() - etc. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…eader Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…heme(string_view) Also no more custom `starts_with` utility function. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
This was referenced May 21, 2020
|
LGTM label has been added. Git tree hash: 80f55cf073856fd86f44930b4b96c939f3dc7415
|
mstemm
approved these changes
May 21, 2020
| # By default the gRPC server is off. | ||
| # You can configure the address to bind and expose it. | ||
| # By modifying the threadiness configuration you can fine-tune the number of threads (and context) it will use. | ||
| # grpc: |
There was a problem hiding this comment.
I don't have a strong preference, but maybe we should make a unix socket the default?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #858
Special notes for your reviewer:
Does this PR introduce a user-facing change?: