Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: fix macro reference #1224

Merged
merged 1 commit into from
May 21, 2020
Merged

rule update: fix macro reference #1224

merged 1 commit into from
May 21, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented May 20, 2020

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Fix a macro reference

Which issue(s) this PR fixes:
Macro remote_file_copy_procs reference to macro remote_file_copy_procs with typo.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro remote_file_copy_procs): fix reference to remote_file_copy_binaries

Signed-off-by: kaizhe <derek0405@gmail.com>
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@poiana
Copy link

poiana commented May 20, 2020

LGTM label has been added.

Git tree hash: 516cb704094edcc62394a9a332b77066f07401da

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@poiana poiana merged commit d1af7e1 into master May 21, 2020
@poiana poiana deleted the kh_fix-macro-reference branch May 21, 2020 08:56
@poiana
Copy link

poiana commented May 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido added this to the 0.24.0 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants