build: libyaml in bundled deps #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold This needs more testing with the packages to avoid breaking the release. |
|
We also probably want to remove libyaml from the builder docker image |
👍 |
leogr
reviewed
Jun 22, 2020
There was a problem hiding this comment.
Overall SGTM.
Please note that I have removed the dep from builder, but:
- the
falcosecurity/builderimage needs to be manually pushed (just a reminder) - by removing
libyaml-0-2from the builder, we also are removing the ability to build old Falco versions, do we need to maintain that backward compatibility? I don't think so - I have tested the flow, and it seems to work, but I will check it again
- docker/local still use this dep, but since the
docker/localseems to be not used I would take of that in separate PR
fntlnz
force-pushed
the
build/bundled-libyaml
branch
from
e5dd92a
to
5632d49
Compare
fntlnz
commented
Jul 13, 2020
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
leogr
force-pushed
the
build/bundled-libyaml
branch
from
5632d49
to
dcd6964
Compare
|
LGTM label has been added. Git tree hash: e91c408eb79c72090cbe5e336a64525cf5d47c7d
|
leodido
approved these changes
Jul 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.25.0 |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lorenzo Fontana lo@linux.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
There's no reason we rely on system libyaml when we release since it doesn't add many MB to the build and doesn't require a long time to build either.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: